[PATCH] D115653: [DAG]Introduce llvm::processShuffleMasks and use it for shuffles in DAG Type Legalizer.

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 7 08:37:15 PDT 2022


dmgreen added a comment.

I'm not sure I understand all the ramifications of this, but the Arm/AArch64 tests look OK to me (or I have plans to do something to improve them).



================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp:2215
+    for (unsigned Idx = 0; Idx < array_lengthof(Inputs); ++Idx) {
+      SDValue &Input = Inputs[Idx];
+      auto *Shuffle = dyn_cast<ShuffleVectorSDNode>(Input.getNode());
----------------
SDValue can usually be passed by value just fine.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115653/new/

https://reviews.llvm.org/D115653



More information about the llvm-commits mailing list