[PATCH] D116465: [SPIRV 6/6] Add the module analysis pass and the simplest tests

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 7 06:35:25 PDT 2022


arsenm added a comment.

In D116465#3432021 <https://reviews.llvm.org/D116465#3432021>, @rengolin wrote:

> Apologies, it seems I was looking into a very old version of the review!
>
> This looks good to me. @arsenm did that answer your comment?

Yes, but it points to another issue (one that SPIRV specifically probably doesn't care about)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116465/new/

https://reviews.llvm.org/D116465



More information about the llvm-commits mailing list