[PATCH] D122887: [llvm-pdbutil] Move global state (Filters) inside LinePrinter class.

Alexandre Ganea via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 7 06:24:04 PDT 2022

Previous message: [PATCH] D122887: [llvm-pdbutil] Move global state (Filters) inside LinePrinter class.
Next message: [PATCH] D122887: [llvm-pdbutil] Move global state (Filters) inside LinePrinter class.
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

aganea added a comment.

Do you think it would be possible to omit `Optional` and just pass `PrintScope &HeaderScope` everywhere? It feels like without the printer, these functions don't have much purpose?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122887/new/

https://reviews.llvm.org/D122887

Previous message: [PATCH] D122887: [llvm-pdbutil] Move global state (Filters) inside LinePrinter class.
Next message: [PATCH] D122887: [llvm-pdbutil] Move global state (Filters) inside LinePrinter class.
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the llvm-commits mailing list