[PATCH] D122584: [DebugInfo] Use DW_ATE_signed encoding when creating a Fortran array index type.

[Paul Robinson via Phabricator via llvm-commits]

probinson added a comment.

In D122584#3434184 <https://reviews.llvm.org/D122584#3434184>, @dblaikie wrote:

> Oh, this goes back in time a bit of a ways indeed (thanks for the archaeology) - so there was probably no pre-commit review, and the post-commit review doesn't seem to have discussed this aspect of the design, just some other naming details: https://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20121203/thread.html#158001

FWIW: My memory is that he first committed it to use zero always, then I pointed out the default lower bound was language-dependent.  This is specified in DWARF itself.

Whether the bound should be signed or unsigned....  I expect there are other languages that allow negative bounds, I feel pretty sure I've used PL/I code that did that.  If I'd noticed this review earlier I might have voted for making the frontend do something, but I'm okay with it being a language-code based decision as done here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122584/new/

https://reviews.llvm.org/D122584