[PATCH] D123014: [X86][FastISel] Remove with.overflow + select fold (PR54369)

[Phoebe Wang via Phabricator via llvm-commits]

pengfei added a comment.

In D123014#3435488 <https://reviews.llvm.org/D123014#3435488>, @RKSimon wrote:

> In D123014#3429542 <https://reviews.llvm.org/D123014#3429542>, @nikic wrote:
>
>> @RKSimon Here's how dropping it entirely looks like: https://gist.github.com/nikic/9e59e8e7b635a54f0d75aad89b2632d6
>
> I think I prefer getting rid of it entirely, but I'd accept just this patch if others want to keep some eflags folding behaviour.
>
> @pengfei @craig.topper any thoughts?

If I read the patches correct, this patch and further removing the whole folding are just for theoretical potential issues but we cannot think out for now, right?
Given we don't do much optimizations with FastISel (which means it's rare we meet another fail in future), I prefer to D122825 <https://reviews.llvm.org/D122825> (maybe with comments for future information). Furthermore, I think we can even check if the constant is 0.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123014/new/

https://reviews.llvm.org/D123014