[PATCH] D121171: [flang] Add ExternalNameConversionPass to flang-new pipeline

Andrzej Warzynski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 7 03:37:55 PDT 2022


awarzynski added a comment.

In D121171#3432214 <https://reviews.llvm.org/D121171#3432214>, @rovka wrote:

> I think adding -mmlir is the best way to handle this, but that should clearly be a separate patch.

I agree :) I gave it a go and here's the result: https://reviews.llvm.org/D123297

> To be honest, I'm probably more interested in why these isolated tests need to run the whole pipeline in the first place. I'm not against end-to-end testing where it makes sense, but these 2 tests look like a pretty random subset and could use some comments about what exactly they're trying to achieve.

My thoughts exactly.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121171/new/

https://reviews.llvm.org/D121171



More information about the llvm-commits mailing list