[PATCH] D122967: [InstCombine] fold more constant divisor to select-of-constants divisor

Chenbing.Zheng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 7 02:26:04 PDT 2022


Chenbing.Zheng marked 2 inline comments as done.
Chenbing.Zheng added inline comments.


================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineInternal.h:626
+  Instruction *FoldOpIntoSelect(Instruction &Op, SelectInst *SI,
+                                bool Tend = false);
 
----------------
RKSimon wrote:
> 'Tend' sounds odd to me - maybe something like 'FoldWithMultiUse' to be more descriptive?
> 'Tend' sounds odd to me - maybe something like 'FoldWithMultiUse' to be more descriptive?

Thanks for suggestion, it is mush batter


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122967/new/

https://reviews.llvm.org/D122967



More information about the llvm-commits mailing list