[PATCH] D120880: [AArch64] Insert subvector costs

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 7 02:14:39 PDT 2022


dmgreen added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp:2724
+        TLI->getTypeLegalizationCost(DL, SubTp);
+    if (SubLT.second.isVector()) {
+      int NumElts = LT.second.getVectorNumElements();
----------------
sdesmalen wrote:
> nit: Is this condition already implied by the fact that Kind == TTI::SK_InsertSubvector?
It is trying to defend against strange types which legalize to a scalar type.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120880/new/

https://reviews.llvm.org/D120880



More information about the llvm-commits mailing list