[PATCH] D123292: [RISCV][NFC] Use defvar to simplify pattern definations.

Fraser Cormack via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 7 02:11:34 PDT 2022


frasercrmck accepted this revision.
frasercrmck added a comment.
This revision is now accepted and ready to land.

LGTM, nice cleanup, thanks



================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoVSDPatterns.td:356
+              (!cast<Instruction>(instruction_name#"_VX_"#vti.LMul.MX)
+                 vti.RegClass:$rs2, GPR:$rs1,
+                 vti.AVL, vti.Log2SEW)>;
----------------
could maybe be one line if it's less than 80 cols? (here and below)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123292/new/

https://reviews.llvm.org/D123292



More information about the llvm-commits mailing list