[PATCH] D122967: [InstCombine] fold more constant divisor to select-of-constants divisor

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineInternal.h:626
+  Instruction *FoldOpIntoSelect(Instruction &Op, SelectInst *SI,
+                                bool Tend = false);
 
----------------
'Tend' sounds odd to me - maybe something like 'FoldWithMultiUse' to be more descriptive?


================
Comment at: llvm/test/Transforms/InstCombine/div.ll:17
+; CHECK-NEXT:    [[B1:%.*]] = lshr i32 [[A:%.*]], 3
+; CHECK-NEXT:    ret i32 [[B1]]
 ;
----------------
Are these changes from this patch or should you regenerate the file before hand to get rid of seperate changes like this?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122967/new/

https://reviews.llvm.org/D122967