[lld] e4b2862 - [lld-macho][nfc] Rearrange order of statements to clarify data dependencies

[Jez Ng via llvm-commits]

Author: Jez Ng
Date: 2022-04-07T00:00:41-04:00
New Revision: e4b286211c5ad06ec2536c6b57297bc87c460684

URL: https://github.com/llvm/llvm-project/commit/e4b286211c5ad06ec2536c6b57297bc87c460684
DIFF: https://github.com/llvm/llvm-project/commit/e4b286211c5ad06ec2536c6b57297bc87c460684.diff

LOG: [lld-macho][nfc] Rearrange order of statements to clarify data dependencies

Added: 
    

Modified: 
    lld/MachO/InputFiles.cpp

Removed: 
    


################################################################################
diff  --git a/lld/MachO/InputFiles.cpp b/lld/MachO/InputFiles.cpp
index 41fb45ccdfc3d..42bea7c8d6246 100644
--- a/lld/MachO/InputFiles.cpp
+++ b/lld/MachO/InputFiles.cpp
@@ -296,9 +296,6 @@ void ObjFile::parseSections(ArrayRef<SectionHeader> sectionHeaders) {
         StringRef(sec.sectname, strnlen(sec.sectname, sizeof(sec.sectname)));
     StringRef segname =
         StringRef(sec.segname, strnlen(sec.segname, sizeof(sec.segname)));
-    ArrayRef<uint8_t> data = {isZeroFill(sec.flags) ? nullptr
-                                                    : buf + sec.offset,
-                              static_cast<size_t>(sec.size)};
     sections.push_back(make<Section>(this, segname, name, sec.flags, sec.addr));
     if (sec.align >= 32) {
       error("alignment " + std::to_string(sec.align) + " of section " + name +
@@ -307,6 +304,9 @@ void ObjFile::parseSections(ArrayRef<SectionHeader> sectionHeaders) {
     }
     const Section &section = *sections.back();
     uint32_t align = 1 << sec.align;
+    ArrayRef<uint8_t> data = {isZeroFill(sec.flags) ? nullptr
+                                                    : buf + sec.offset,
+                              static_cast<size_t>(sec.size)};
 
     auto splitRecords = [&](int recordSize) -> void {
       if (data.empty())