[PATCH] D123262: AMDGPU: Set implicit kernarg size to be of 256 bytes for code object version 5

[Changpeng Fang via Phabricator via llvm-commits]

cfang added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/llvm.amdgcn.implicitarg.ptr.ll:5
 
-; GCN-LABEL: {{^}}kernel_implicitarg_ptr_empty:
+; CHECK-LABEL: {{^}}kernel_implicitarg_ptr_empty:
 ; HSA: enable_sgpr_kernarg_segment_ptr = 1
----------------
arsenm wrote:
> This is broken. You need to add back the GCN check prefix
Can you tell how this is broken? It passed the test for my check.
The problem is that, if we add back the GCN check prefix, the COV5 check won't be able to check the label (When I add prefix to COV5 cases, the test will fail GCN check because COV5 is quite different).   


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123262/new/

https://reviews.llvm.org/D123262