[PATCH] D123178: [RISCV] Store/restore RISCVMachineFunctionInfo into MIR YAML file

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 6 19:49:09 PDT 2022


craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVTargetMachine.cpp:241
+  const auto &YamlMFI =
+      reinterpret_cast<const yaml::RISCVMachineFunctionInfo &>(MFI);
+  MachineFunction &MF = PFS.MF;
----------------
craig.topper wrote:
> What makes this need a reinterpret_cast instead of a static_cast? I see that other targets are also using reinterpret_cast but I don't understand them either.
I pushed a fix to use static_cast on the other targets.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123178/new/

https://reviews.llvm.org/D123178



More information about the llvm-commits mailing list