[PATCH] D121938: [flang] expand the num_images test coverage

Katherine Rasmussen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 6 15:22:18 PDT 2022


ktras requested changes to this revision.
ktras added a comment.
This revision now requires changes to proceed.

Since `num_images()` can have a single argument of `team` or `team_number` or no argument at all, adding the keyword arguments for these expected errors narrows the focus that you are trying to test that the `team_number` argument specifically shall not be a scalar and same with `team`. So I suggest adding these keyword arguments here.



================
Comment at: flang/test/Semantics/num_images02.f90:36
+  !ERROR: too many actual arguments for intrinsic 'num_images'
+  n = num_images(array)
+
----------------



================
Comment at: flang/test/Semantics/num_images02.f90:40
+  !ERROR: too many actual arguments for intrinsic 'num_images'
+  n = num_images(league)
+
----------------



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121938/new/

https://reviews.llvm.org/D121938



More information about the llvm-commits mailing list