[PATCH] D122584: [DebugInfo] Use DW_ATE_signed encoding when creating a Fortran array index type.

Wed Apr 6 13:16:33 PDT 2022

dblaikie added a comment.

In D122584#3433987 <https://reviews.llvm.org/D122584#3433987>, @cchen15 wrote:

> @dblaikie: A quick git blame shows that the original code for getDefaultLowerBound was added to DwarfCompileUnit.cpp in the following commit in 2012:
>
> commit 28fe9e7a3675795aff7fb0f22b95ffe0c682b5de
> Author: Bill Wendling <isanbard at gmail.com>
> Date:   Thu Dec 6 07:38:10 2012 +0000
>
>   Handle non-default array bounds.
>   
>   Some languages, e.g. Ada and Pascal, allow you to specify that the array bounds
>   are different from the default (1 in these cases). If we have a lower bound
>   that's non-default, then we emit the lower bound. We also calculate the correct
>   upper bound in those cases.
>   
>   llvm-svn: 169484
>
> In Nov/Dec 2013, this piece of code was migrated to DwarfUnit.cpp.
>
> Is there a way to look at the discussion in 'llvm-svn: 169484'?

Oh, this goes back in time a bit of a ways indeed (thanks for the archaeology) - so there was probably no pre-commit review, and the post-commit review doesn't seem to have discussed this aspect of the design, just some other naming details: https://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20121203/thread.html#158001

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122584/new/

https://reviews.llvm.org/D122584