[PATCH] D122584: [DebugInfo] Use DW_ATE_signed encoding when creating a Fortran array index type.

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 6 12:01:22 PDT 2022


dblaikie added a comment.

In D122584#3423262 <https://reviews.llvm.org/D122584#3423262>, @aprantl wrote:

> Thanks for showing me a counterexample! I still don't think it's great if AsmPrinter needs to know language-specific details so I would still prefer to have this decision made in the fronted and passing to the backend in DISubrange. @dblaikie what do you think?

Hey, sorry for the delay. I totally get where you're coming from - might be worth double checking the discussion from the previous instance of this/prior art to see if this is consistent or not, whether there's a breaking point where we go back and overhaul a bunch of this stuff - but yeah, it's probably OK-ish?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122584/new/

https://reviews.llvm.org/D122584



More information about the llvm-commits mailing list