[PATCH] D122740: [demangler] Node precision dumper

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

In D122740#3430230 <https://reviews.llvm.org/D122740#3430230>, @urnathan wrote:

> In D122740#3424667 <https://reviews.llvm.org/D122740#3424667>, @dblaikie wrote:
>
>> can/should this have test coverage?
>
> Doesn't look simple.  This is inside NDEBUG and explicitly writes to stderr, so I'm not sure how to capture that?

Ah, I actually just was glancing at a commit that tested a situation like this ( rG9a62d9db2e1f6064e6c20344870f5e9d43a8de43 <https://reviews.llvm.org/rG9a62d9db2e1f6064e6c20344870f5e9d43a8de43> ) - so it can be/is done by `REQUIRES: asserts` on a lit test and then checking stderr (possibly/usually by `2>&1` to just collapse stderr and stdout together).

I'd expect/hope there is already other test coverage for this general feature that you could extend - or is this whole printing system  untested?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122740/new/

https://reviews.llvm.org/D122740