[PATCH] D123064: [Clang][C++23][WIP] P2071 Named universal character escapes

Corentin Jabot via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 6 10:58:39 PDT 2022


cor3ntin updated this revision to Diff 420946.
cor3ntin added a comment.

- Typo fixes for invalid code points

Add a method `NearestMatchesForCodepointName` that will return the N closest
valid codepoints, by edit distance.
This is used to detect typos in named escape sequences in literals.

- Address some of Tom's comments:
  - Add test for '\N{ABC'.
  - Handle loose matching of named ucns in identifiers with appropriate diagnostics.
  - Fix detection of the difference betwen empty and incomplete named escape sequences.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123064/new/

https://reviews.llvm.org/D123064

Files:
  clang/include/clang/Basic/DiagnosticLexKinds.td
  clang/include/clang/Lex/Lexer.h
  clang/lib/Lex/Lexer.cpp
  clang/lib/Lex/LiteralSupport.cpp
  clang/test/Lexer/char-escapes-delimited.c
  clang/test/Parser/cxx11-user-defined-literals.cpp
  clang/test/Preprocessor/ucn-pp-identifier.c
  clang/test/Sema/ucn-identifiers.c
  llvm/CMakeLists.txt
  llvm/include/llvm/ADT/StringExtras.h
  llvm/include/llvm/Support/ScopedPrinter.h
  llvm/include/llvm/Support/Unicode.h
  llvm/lib/Support/CMakeLists.txt
  llvm/lib/Support/ScopedPrinter.cpp
  llvm/lib/Support/StringExtras.cpp
  llvm/lib/Support/UnicodeNameToCodepoint.cpp
  llvm/lib/Support/UnicodeNameToCodepointGenerated.cpp
  llvm/unittests/Support/UnicodeTest.cpp
  llvm/utils/UnicodeData/CMakeLists.txt
  llvm/utils/UnicodeData/UnicodeNameMappingGenerator.cpp



More information about the llvm-commits mailing list