[PATCH] D120714: [CodeGen] Place SDNode debug ID declaration under appropriate #if

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 6 09:35:22 PDT 2022


thakis added a comment.

I think we should revert this then. It makes a whole bunch of tests not run by default when abi_breaking_checks are off, and it kind of needlessly adds abi_breaking_checks as a lit feature. Having fewer lit features is desirable, and if this doesn't have a measurable benefit I don't think we should take on that cost.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120714/new/

https://reviews.llvm.org/D120714



More information about the llvm-commits mailing list