[PATCH] D123052: InstCombineCalls: infer return alignment from allocalign attributes

Augie Fackler via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 6 09:12:14 PDT 2022


durin42 marked an inline comment as done.
durin42 added inline comments.


================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineCalls.cpp:2848
-  if (isAllocationFn(&Call, &TLI))
-    annotateAnyAllocSite(Call, &TLI);
 
----------------
nikic wrote:
> We're missing change reporting here -- annotateAnyAllocSite should return a boolean and we should initialize Changed with it. But this is orthogonal to your change here.
Sent a follow-up as D123232 (it's at the end of the stack now, but I'm happy to submit it if it's LG and this one is also ready)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123052/new/

https://reviews.llvm.org/D123052



More information about the llvm-commits mailing list