[PATCH] D123178: [RISCV] Store/restore RISCVMachineFunctionInfo into MIR YAML file

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVMachineFunctionInfo.h:29
+  int VarArgsSaveSize;
+  int MoveF64FrameIndex;
+
----------------
Why is `MoveF64FrameIndex` in here but never referenced anywhere else.


================
Comment at: llvm/lib/Target/RISCV/RISCVTargetMachine.cpp:241
+  const auto &YamlMFI =
+      reinterpret_cast<const yaml::RISCVMachineFunctionInfo &>(MFI);
+  MachineFunction &MF = PFS.MF;
----------------
What makes this need a reinterpret_cast instead of a static_cast? I see that other targets are also using reinterpret_cast but I don't understand them either.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123178/new/

https://reviews.llvm.org/D123178