[PATCH] D123218: [dsymutil] Fix O(n^2) behavior when running on ld64.lld's current ICF output

[Jonas Devlieghere via Phabricator via llvm-commits]

JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.

Thanks Nico. LGTM modulo the inline nit.



================
Comment at: llvm/tools/dsymutil/MachODebugMapParser.cpp:68
+  /// If CurrentObjectAliasMap has been computed for a given address.
+  SmallSet<uint64_t, 4> SeenValues;
+
----------------
`SeenValues` sounds a bit generic. Maybe something like `SeenAliasValues` would make it more obvious that this is specific to aliases?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123218/new/

https://reviews.llvm.org/D123218