[PATCH] D123185: [LLD][COFF] Fix TypeServerSource matcher with more than one collision

[Alexandre Ganea via Phabricator via llvm-commits]

aganea accepted this revision.
aganea added a comment.

LGTM.



================
Comment at: lld/test/COFF/pdb-type-server-guid-collision-invalid.test:9
 RUN: yaml2obj %p/Inputs/pdb-type-server-guid-collision-b.yaml -o b.obj
+RUN: sed s/b.pdb/c.pdb/ %S/Inputs/pdb-type-server-guid-collision-b.yaml | sed s/b.obj/c.obj/ | sed s/bar_gv/rab_gv/ | sed s/Bar/Rab/ | yaml2obj > c.obj
 RUN: llvm-pdbutil yaml2pdb %S/Inputs/pdb-type-server-guid-collision-a-pdb.yaml -pdb a.pdb
----------------
thieta wrote:
> aganea wrote:
> > Are you able to repro the issue with this test, but with the old code from rG98bc304e9faded44f1d8988ffa4c5d8b50c759ec? If so, all good!
> Yes - I wrote the test for the old rev and made sure it failed first.
Cool - thanks! ;-)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123185/new/

https://reviews.llvm.org/D123185