[PATCH] D123185: [LLD][COFF] Fix TypeServerSource matcher with more than one collision

[Alexandre Ganea via Phabricator via llvm-commits]

aganea added a comment.

In D123185#3433103 <https://reviews.llvm.org/D123185#3433103>, @thieta wrote:

> @aganea Added more testing - adding a third collision and also probe all the types and in different orders, since the order fooled the testing the first time since the order they where processed in LLD  made a difference for the output.
>
> I had to drop the log message since when we know set the entry to nullptr there is nothing informative to log, but I am not convinced the log message was that useful and I really don't think it's worth adding some more complexity to store the paths of all collisions.
>
> WDYT?

I agree, you can leave out the logging.



================
Comment at: lld/test/COFF/pdb-type-server-guid-collision-invalid.test:9
 RUN: yaml2obj %p/Inputs/pdb-type-server-guid-collision-b.yaml -o b.obj
+RUN: sed s/b.pdb/c.pdb/ %S/Inputs/pdb-type-server-guid-collision-b.yaml | sed s/b.obj/c.obj/ | sed s/bar_gv/rab_gv/ | sed s/Bar/Rab/ | yaml2obj > c.obj
 RUN: llvm-pdbutil yaml2pdb %S/Inputs/pdb-type-server-guid-collision-a-pdb.yaml -pdb a.pdb
----------------
Are you able to repro the issue with this test, but with the old code from rG98bc304e9faded44f1d8988ffa4c5d8b50c759ec? If so, all good!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123185/new/

https://reviews.llvm.org/D123185