[PATCH] D123185: [LLD][COFF] Follow-up on 98bc304 - make collision case faster
Tobias Hieta via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Apr 6 08:12:42 PDT 2022
thieta added a comment.
@aganea Added more testing - adding a third collision and also probe all the types and in different orders, since the order fooled the testing the first time since the order they where processed in LLD made a difference for the output.
I had to drop the log message since when we know set the entry to nullptr there is nothing informative to log, but I am not convinced the log message was that useful and I really don't think it's worth adding some more complexity to store the paths of all collisions.
WDYT?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D123185/new/
https://reviews.llvm.org/D123185
More information about the llvm-commits
mailing list