[PATCH] D123143: SelectionDAG: Swap operands of atomic_store

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 6 05:57:18 PDT 2022


foad added inline comments.


================
Comment at: llvm/include/llvm/Target/TargetSelectionDAG.td:1630
 
+def atomic_store_8 :
+  PatFrag<(ops node:$val, node:$ptr),
----------------
Before your patch, where were these defined?


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp:1766
 SDValue DAGTypeLegalizer::PromoteIntOp_ATOMIC_STORE(AtomicSDNode *N) {
-  SDValue Op2 = GetPromotedInteger(N->getOperand(2));
+  SDValue Op2 = GetPromotedInteger(N->getOperand(1));
   return DAG.getAtomic(N->getOpcode(), SDLoc(N), N->getMemoryVT(),
----------------
Rename to Op1?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123143/new/

https://reviews.llvm.org/D123143



More information about the llvm-commits mailing list