[PATCH] D122431: Basic support for posix_memalign / __builtin_object_size interaction

[Nikita Popov via Phabricator via llvm-commits]

nikic accepted this revision.
nikic added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/Analysis/MemoryBuiltins.cpp:905
+      if (!C)
+        return unknown();
+
----------------
Should be `Unknown()`.


================
Comment at: llvm/test/Transforms/LowerConstantIntrinsics/builtin-object-size-load.ll:2
+; NOTE: Assertions have been autogenerated by utils/update_test_checks.py
+; RUN: opt --instcombine -lower-constant-intrinsics -S < %s | FileCheck %s
+
----------------
We should pass in the AA parameter in LowerConstantIntrinsics to avoid the need for `-instcombine` here, but we can do that separately...


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122431/new/

https://reviews.llvm.org/D122431