[PATCH] D120483: [flang] Handle allocatable dummy arguments

[Roger Ferrer Ibanez via Phabricator via llvm-commits]

rogfer01 added inline comments.
Herald added a project: All.


================
Comment at: flang/lib/Lower/CallInterface.cpp:658
+      // Need to pass type parameters in fir.box if any.
+      return derived->parameters().empty();
+    return false;
----------------
I am curious about this. Does this mean that a type like

```lang=fortran
type foo
   integer :: x  
end type foo
```

is boxed (its number of parameters is empty) while


```lang=fortran
type foo2(l)
  integer, len :: l 
  integer :: x  
end type foo2
```

is not boxed (its number of parameters is not empty).

Maybe the intent of the code is the opposite?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120483/new/

https://reviews.llvm.org/D120483