[PATCH] D123150: [RISCV] Add lowering for vp.sext and vp.zext.

[Fraser Cormack via Phabricator via llvm-commits]

frasercrmck accepted this revision.
frasercrmck added a comment.

LGTM with some nits.



================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:3693
+  case ISD::VP_SEXT:
+  case ISD::VP_ZEXT: {
+    if (Op.getOperand(0).getSimpleValueType().getVectorElementType() == MVT::i1)
----------------
Not sure you need these parens, strictly speaking


================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:3696
+      return lowerVPExtMaskOp(Op, DAG);
+    return lowerVPOp(Op, DAG, Op.getOpcode() == ISD::VP_SEXT ? RISCVISD::VSEXT_VL : RISCVISD::VZEXT_VL);
+  }
----------------
I'm surprised clang-format isn't complaining about this long line.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123150/new/

https://reviews.llvm.org/D123150