[PATCH] D123196: [AArch64] Refactor shouldExpandAtomicRMWInIR [NFC]

[Tomas Matheson via Phabricator via llvm-commits]

tmatheson created this revision.
Herald added subscribers: hiraditya, kristof.beyls.
Herald added a project: All.
tmatheson requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Convert to a sequence of early returns to make the logic easier to follow.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D123196

Files:
  llvm/lib/Target/AArch64/AArch64ISelLowering.cpp


Index: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp
===================================================================
--- llvm/lib/Target/AArch64/AArch64ISelLowering.cpp
+++ llvm/lib/Target/AArch64/AArch64ISelLowering.cpp
@@ -19388,39 +19388,52 @@
   if (AI->isFloatingPointOperation())
     return AtomicExpansionKind::CmpXChg;
 
+  // At -O0, fast-regalloc cannot cope with the live vregs necessary to
+  // implement atomicrmw without spilling. If the target address is also on the
+  // stack and close enough to the spill slot, this can lead to a situation
+  // where the monitor always gets cleared and the atomic operation can never
+  // succeed. So at -O0 lower this operation to a CAS loop.
+  auto OptLevelDefault = getTargetMachine().getOptLevel() == CodeGenOpt::None
+                             ? AtomicExpansionKind::CmpXChg
+                             : AtomicExpansionKind::LLSC;
+
   unsigned Size = AI->getType()->getPrimitiveSizeInBits();
   if (Size > 128) return AtomicExpansionKind::None;
 
-  // Nand is not supported in LSE.
   // Leave 128 bits to LLSC or CmpXChg.
-  if (AI->getOperation() != AtomicRMWInst::Nand && Size < 128) {
-    if (Subtarget->hasLSE())
-      return AtomicExpansionKind::None;
-    if (Subtarget->outlineAtomics()) {
-      // [U]Min/[U]Max RWM atomics are used in __sync_fetch_ libcalls so far.
-      // Don't outline them unless
-      // (1) high level <atomic> support approved:
-      //   http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2020/p0493r1.pdf
-      // (2) low level libgcc and compiler-rt support implemented by:
-      //   min/max outline atomics helpers
-      if (AI->getOperation() != AtomicRMWInst::Min &&
-          AI->getOperation() != AtomicRMWInst::Max &&
-          AI->getOperation() != AtomicRMWInst::UMin &&
-          AI->getOperation() != AtomicRMWInst::UMax) {
-        return AtomicExpansionKind::None;
-      }
-    }
+  if (Size == 128)
+    return OptLevelDefault;
+
+  // Nand is not supported in LSE.
+  if (AI->getOperation() == AtomicRMWInst::Nand)
+    return OptLevelDefault;
+
+  if (Subtarget->hasLSE()) {
+    assert(AI->getOperation() != AtomicRMWInst::Nand);
+    assert(Size < 128);
+    return AtomicExpansionKind::None;
   }
 
-  // At -O0, fast-regalloc cannot cope with the live vregs necessary to
-  // implement atomicrmw without spilling. If the target address is also on the
-  // stack and close enough to the spill slot, this can lead to a situation
-  // where the monitor always gets cleared and the atomic operation can never
-  // succeed. So at -O0 lower this operation to a CAS loop.
-  if (getTargetMachine().getOptLevel() == CodeGenOpt::None)
-    return AtomicExpansionKind::CmpXChg;
+  if (Subtarget->outlineAtomics()) {
+    assert(AI->getOperation() != AtomicRMWInst::Nand);
+    assert(Size < 128);
+    assert(!Subtarget->hasLSE());
+    // [U]Min/[U]Max RWM atomics are used in __sync_fetch_ libcalls so far.
+    // Don't outline them unless
+    // (1) high level <atomic> support approved:
+    //   http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2020/p0493r1.pdf
+    // (2) low level libgcc and compiler-rt support implemented by:
+    //   min/max outline atomics helpers
+    if (AI->getOperation() == AtomicRMWInst::Min ||
+        AI->getOperation() == AtomicRMWInst::Max ||
+        AI->getOperation() == AtomicRMWInst::UMin ||
+        AI->getOperation() == AtomicRMWInst::UMax) {
+      return OptLevelDefault;
+    }
+    return AtomicExpansionKind::None;
+  }
 
-  return AtomicExpansionKind::LLSC;
+  return OptLevelDefault;
 }
 
 TargetLowering::AtomicExpansionKind


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D123196.420749.patch
Type: text/x-patch
Size: 3627 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220406/05160eea/attachment.bin>