[PATCH] D121642: InstCombineCalls: when adding an align attribute, never reduce it

[Nikita Popov via Phabricator via llvm-commits]

nikic accepted this revision.
nikic added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineCalls.cpp:2843
+      if (NewAlign > ExistingAlign) {
+        Call.removeRetAttr(Attribute::Alignment);
+        Call.addRetAttr(
----------------
While you're here: This explicit removeRetAttr shouldn't be necessary. addRetAttr overwrites an existing attribute.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121642/new/

https://reviews.llvm.org/D121642