[PATCH] D123052: InstCombineCalls: infer return alignment from allocalign attributes

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 6 02:10:49 PDT 2022


nikic accepted this revision.
nikic added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineCalls.cpp:2848
-  if (isAllocationFn(&Call, &TLI))
-    annotateAnyAllocSite(Call, &TLI);
 
----------------
We're missing change reporting here -- annotateAnyAllocSite should return a boolean and we should initialize Changed with it. But this is orthogonal to your change here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123052/new/

https://reviews.llvm.org/D123052



More information about the llvm-commits mailing list