[PATCH] D116465: [SPIRV 6/6] Add the module analysis pass and the simplest tests

[Ilia Diachkov via Phabricator via llvm-commits]

iliya-diyachkov added a comment.

In D116465#3431960 <https://reviews.llvm.org/D116465#3431960>, @rengolin wrote:

> This one still has some unactioned comments...

@rengolin, do you mean that some issues pointed out by Matt have not been fixed? I thought everything was done, except for the suggestion to use getSubtarget<SPIRVSubtarget>() instead of static_cast in SPIRVAsmPrinter constructor. I explained that it was not clear how to efficiently apply this suggestion to our case.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116465/new/

https://reviews.llvm.org/D116465