[PATCH] D123180: [RISCV] Fixing stack offset for RVV object with vararg in stack.

Kito Cheng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 5 21:23:07 PDT 2022


kito-cheng added a comment.

Note, I didn't use `update_mir_test_checks.py` for the testcase since I try to keep stack layout in the check, and that script will generate checks for function body only.



================
Comment at: llvm/test/CodeGen/RISCV/wrong-stack-offset-for-rvv-object.mir:23
 # | Stack ID 6               |
 # |--------------------------| -- <-- New SP
 
----------------
See detailed stack layout diagram here.


================
Comment at: llvm/test/CodeGen/RISCV/wrong-stack-offset-for-rvv-object.mir:167
   ; CHECK-NEXT:   renamable $v8 = PseudoVMV_V_I_MF8 0, 2, 3, implicit $vl, implicit $vtype
-  ; CHECK-NEXT:   $x10 = ADDI $x2, 40
   ; CHECK-NEXT:   PseudoVSPILL_M1 killed renamable $v8, killed $x10 :: (store unknown-size into %stack.1, align 8)
----------------
So 40 is apparently wrong offset according the stack layout diagram.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123180/new/

https://reviews.llvm.org/D123180



More information about the llvm-commits mailing list