[PATCH] D122872: [CSKY] Fix some Clang warnings. NFC

[Zixuan Wu via Phabricator via llvm-commits]

zixuan-wu accepted this revision.
zixuan-wu added a comment.
This revision is now accepted and ready to land.

In D122872#3421455 <https://reviews.llvm.org/D122872#3421455>, @zixuan-wu wrote:

> Thank you for this patch. I was also going to draft it. Following unused variable in td file can also be removed.
>
>   diff --git a/llvm/lib/Target/CSKY/CSKYInstrFormats.td b/llvm/lib/Target/CSKY/CSKYInstrFormats.td
>   index 9b6ef9c..8144a50 100644
>   --- a/llvm/lib/Target/CSKY/CSKYInstrFormats.td
>   +++ b/llvm/lib/Target/CSKY/CSKYInstrFormats.td
>   @@ -655,7 +655,7 @@ class R_Z_1<bits<6> sop, bits<5> pcode, string op>
>   
>    // Format< OP[6] | RZ[5] | 00000[5] | SOP[6] | PCODE[5] | 00000[5] >
>    // Instructions:(2) clrf32, clrt32
>   -class R_Z_2<bits<6> sop, bits<5> pcode, string op, list<dag> pattern>
>   +class R_Z_2<bits<6> sop, bits<5> pcode, string op>
>        : CSKY32Inst<AddrModeNone, 0x31, (outs GPR:$rz),
>        (ins CARRY:$ca, GPR:$false), !strconcat(op, "\t$rz"), []> {
>      bits<5> rz;
>   diff --git a/llvm/lib/Target/CSKY/CSKYInstrInfo.td b/llvm/lib/Target/CSKY/CSKYInstrInfo.td
>   index 28e364c..300ecce 100644
>   --- a/llvm/lib/Target/CSKY/CSKYInstrInfo.td
>   +++ b/llvm/lib/Target/CSKY/CSKYInstrInfo.td
>   @@ -734,8 +734,8 @@ let Predicates= [iHasE2] in {
>   
>    let Predicates = [iHas2E3] in {
>      def MVCV32 : R_Z_1<0x1, 0x10, "mvcv32">;
>   -  def CLRF32 : R_Z_2<0xB, 0x1, "clrf32", []>;
>   -  def CLRT32 : R_Z_2<0xB, 0x2, "clrt32", []>;
>   +  def CLRF32 : R_Z_2<0xB, 0x1, "clrf32">;
>   +  def CLRT32 : R_Z_2<0xB, 0x2, "clrt32">;
>    }

I mean you can continue this patch @MaskRay


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122872/new/

https://reviews.llvm.org/D122872