[PATCH] D122251: [lit] Use sharding for GoogleTest format

[Yuanfang Chen via Phabricator via llvm-commits]

ychen updated this revision to Diff 420681.
ychen marked 2 inline comments as done.
ychen added a comment.

Thanks, everyone for the valuable feedback. I believe I addressed all of them in the updated patch.

- @abrachet: makes sure synthesize `result.pid` and `result.start` that are used by `--resultdb-output` and `--time-trace-output`. (with a test case)
- @vitalybuka: makes sure `prepareCmd` is used during the test discovery phase. (added a test case for the GTest wrapper command)
- @thakis: hook up `lit --order=random` to `GTEST_SHUFFLE=1` and when a shard fails, include `GTEST_RANDOM_SEED` in the reproducer script. (this is checked in the updated test)
- @yln: compose new lists instead of modifying existing lists.
- formatting


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122251/new/

https://reviews.llvm.org/D122251

Files:
  llvm/unittests/Support/CrashRecoveryTest.cpp
  llvm/unittests/Support/ProgramTest.cpp
  llvm/utils/lit/lit/LitConfig.py
  llvm/utils/lit/lit/LitTestCase.py
  llvm/utils/lit/lit/Test.py
  llvm/utils/lit/lit/TestingConfig.py
  llvm/utils/lit/lit/formats/googletest.py
  llvm/utils/lit/lit/main.py
  llvm/utils/lit/tests/Inputs/googletest-cmd-wrapper/DummySubDir/OneTest.exe
  llvm/utils/lit/tests/Inputs/googletest-cmd-wrapper/lit.cfg
  llvm/utils/lit/tests/Inputs/googletest-crash/DummySubDir/OneTest.py
  llvm/utils/lit/tests/Inputs/googletest-crash/lit.cfg
  llvm/utils/lit/tests/Inputs/googletest-format/DummySubDir/OneTest.py
  llvm/utils/lit/tests/Inputs/googletest-timeout/DummySubDir/OneTest.py
  llvm/utils/lit/tests/Inputs/googletest-timeout/lit.cfg
  llvm/utils/lit/tests/Inputs/googletest-upstream-format/DummySubDir/OneTest.py
  llvm/utils/lit/tests/Inputs/googletest-upstream-format/lit.cfg
  llvm/utils/lit/tests/googletest-cmd-wrapper.py
  llvm/utils/lit/tests/googletest-crash.py
  llvm/utils/lit/tests/googletest-format.py
  llvm/utils/lit/tests/googletest-timeout.py
  llvm/utils/lit/tests/googletest-upstream-format.py
  llvm/utils/lit/tests/test-output-resultdb.py
  llvm/utils/lit/tests/unit/TestRunner.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D122251.420681.patch
Type: text/x-patch
Size: 43573 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220406/21b7be8c/attachment.bin>