[PATCH] D123173: [llvm-ml] Add support for the -o flag

[Eric Astor via Phabricator via llvm-commits]

epastor requested changes to this revision.
epastor added inline comments.
This revision now requires changes to proceed.


================
Comment at: llvm/test/tools/llvm-ml/output_flag.asm:8-11
+; LLVM_FLAG: t1:
+; MS_FLAG: t1:
+; /Fo takes precedence over -o, so we should still expect to see output
+; BOTH_FLAGS: t1:
----------------
Since we expect the same output in all cases, I don't think we need three different prefixes?

Also, we should probably test that you actually get no output if outputting to /dev/null.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123173/new/

https://reviews.llvm.org/D123173