[PATCH] D118443: Add support for atomic memory copy lowering

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 5 18:04:05 PDT 2022


arsenm accepted this revision.
arsenm added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/unittests/Transforms/Utils/MemTransferLowering.cpp:211
+        EXPECT_TRUE(LoadInst->isAtomic());
+        EXPECT_NE(LoadInst->getMetadata(LLVMContext::MD_alias_scope), nullptr);
+        Instruction *StoreInst =
----------------
Swap these for correct expected/actual message 


================
Comment at: llvm/unittests/Transforms/Utils/MemTransferLowering.cpp:215
+        EXPECT_TRUE(StoreInst->isAtomic());
+        EXPECT_NE(StoreInst->getMetadata(LLVMContext::MD_noalias), nullptr);
+        return PreservedAnalyses::none();
----------------
Ditto


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118443/new/

https://reviews.llvm.org/D118443



More information about the llvm-commits mailing list