[PATCH] D123151: [llvm-symbolizer] Fix line offset for inline site.

Zequan Wu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 5 17:00:38 PDT 2022


zequanwu added a comment.

In D123151#3431077 <https://reviews.llvm.org/D123151#3431077>, @akhuang wrote:

> what's the situation where the "current line offset is actually for next range"?

In the following example, It has the mapping:
`[0x15, 0x20) -> 1`
`[0x20, 0x31) -> 2`
`[0x31, 0x3A) -> 3`
`[0x3A, 0x43) -> 4`

If `OffsetInFunc` is 0x21, the original implementation exits the function after reading 5th line which updates line offset to 3 but it should be 2. line offset 3 is for next code range.

  0602      line 1 (+1)
  0315      code 0x15 (+0x15)
  0B2B      code 0x20 (+0xB) line 2 (+1)
  0602      line 3 (+1)
  0311      code 0x31 (+0x11)
  0B29      code 0x3A (+0x9) line 4 (+1)
  0409      code end 0x43 (+0x9)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123151/new/

https://reviews.llvm.org/D123151



More information about the llvm-commits mailing list