[PATCH] D122929: [BOLT] Check for !isTailCall in isUnconditionalBranch

[Maksim Panchenko via Phabricator via llvm-commits]

maksfb added inline comments.


================
Comment at: bolt/test/AArch64/ext-double-jump.s:10
+  .align 4
+  .global dummy1
+  .type dummy1, %function
----------------
yota9 wrote:
> maksfb wrote:
> > yota9 wrote:
> > > maksfb wrote:
> > > > nit: could you add size directives for functions in the test?
> > > Sure, will do. Does it affect something? I did it before, but usually BOLT works just fine without it, just curious
> > That's the proper way to mark functions in code. Ideally, you also need FDEs. Without this info, BOLT has to rely on heuristics to detect function boundaries.
> Yes, I remember these heuristics, I just thought you've faced with some problems during cross-target tests enabling :)
Ah no, it's just a nit.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122929/new/

https://reviews.llvm.org/D122929