[PATCH] D123160: [AArch64] Limit folded address offsets to 2^20 for COFF

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a subscriber: pcc.
efriedma added a comment.

Please add a testcase.

> Do you agree we should make this dependent on the target OS (or more precisely, object file format), or should we just reduce the universal limit and keep it object file format agnostic?

I'd like to keep the limits of specific formats documented, so future readers can understand why the specific number was chosen.  I don't really care whether that's code or a comment; it's unlikely to matter much in practice.

I'm not actually sure where "1 << 21" comes from, though; I think ELF is unlimited, and MachO is limited to "1 << 23".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123160/new/

https://reviews.llvm.org/D123160