[PATCH] D123152: [WPD] Add statistics

[Mingming Liu via Phabricator via llvm-commits]

luna accepted this revision.
luna added a comment.
This revision is now accepted and ready to land.

LGTM.

Only one question regarding whether the counter is intended for DevirtModule or DevirtIndex (or both)



================
Comment at: llvm/lib/Transforms/IPO/WholeProgramDevirt.cpp:1155
                              TheFn->stripPointerCasts()->getName(), OREGetter);
+      NumSingleImpl++;
       auto &CB = VCallSite.CB;
----------------
If I'm reading correctly, `NumSingleImpl` is incremented in `DevirtModule::applySingleImplDevirt`, but not for `DevirtIndex::trySingleImplDevirt`.

I'm wondering if this is intended for the purpose of this cl. If yes, maybe describe something like 

The counter is incremented in regular LTO (or ThinLTO, etc)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123152/new/

https://reviews.llvm.org/D123152