[compiler-rt] 47e7a22 - [Darwin][ASan][Sanitizer] Enable dlclose-test for all darwin targets.

Roy Sundahl via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 5 12:21:53 PDT 2022


Author: Roy Sundahl
Date: 2022-04-05T12:21:36-07:00
New Revision: 47e7a224711573b48c5b8831d9091c72dfe8b8d3

URL: https://github.com/llvm/llvm-project/commit/47e7a224711573b48c5b8831d9091c72dfe8b8d3
DIFF: https://github.com/llvm/llvm-project/commit/47e7a224711573b48c5b8831d9091c72dfe8b8d3.diff

LOG: [Darwin][ASan][Sanitizer] Enable dlclose-test for all darwin targets.

Test was being skipped on non-x86 darwin architectures.

rdar://79795770

Differential Revision: https://reviews.llvm.org/D123099

Added: 
    

Modified: 
    compiler-rt/test/asan/TestCases/Posix/dlclose-test.cpp

Removed: 
    


################################################################################
diff  --git a/compiler-rt/test/asan/TestCases/Posix/dlclose-test.cpp b/compiler-rt/test/asan/TestCases/Posix/dlclose-test.cpp
index 160c1c940e6f8..db5507a2ea963 100644
--- a/compiler-rt/test/asan/TestCases/Posix/dlclose-test.cpp
+++ b/compiler-rt/test/asan/TestCases/Posix/dlclose-test.cpp
@@ -9,10 +9,10 @@
 // are globals.
 // 6. BOOM
 
-// This sublte test assumes that after a foo.so is dlclose-d
-// we can mmap the region of memory that has been occupied by the library.
-// It works on x86 Linux, but not necessary anywhere else.
-// REQUIRES: x86-target-arch
+// This subtle test assumes that after a foo.so is dlclose-d
+// we can mmap the region of memory that was occupied by the library.
+// This test works on x86 and Darwin, but not confirmed working anywhere else.
+// REQUIRES: x86-target-arch || darwin
 
 // RUN: %clangxx_asan -O0 -DSHARED_LIB %s -fPIC -shared -o %t-so.so
 // RUN: %clangxx_asan -O0 %s %libdl -o %t && %run %t 2>&1 | FileCheck %s


        


More information about the llvm-commits mailing list