[PATCH] D123149: Change the LLVM signpost category

Jonas Devlieghere via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 5 11:58:38 PDT 2022


JDevlieghere created this revision.
JDevlieghere added reviewers: aprantl, pete, dsanders.
Herald added subscribers: dexonsmith, hiraditya.
Herald added a project: All.
JDevlieghere requested review of this revision.
Herald added a project: LLVM.

Currently, the LLVM timers are visible in Instruments for all apps. The Developer-visible "PointsOfInterest" category, is reserved for Runtime Issues and Developer-authored "important" logging. These are visible to developer almost always in Instruments, and having these present in the system is noisy and confusing to developers. The LLVM/LLDB timers do not belong there. Change them to a new "toolchain" category.


https://reviews.llvm.org/D123149

Files:
  llvm/lib/Support/Signposts.cpp


Index: llvm/lib/Support/Signposts.cpp
===================================================================
--- llvm/lib/Support/Signposts.cpp
+++ llvm/lib/Support/Signposts.cpp
@@ -25,7 +25,7 @@
 namespace {
 os_log_t *LogCreator() {
   os_log_t *X = new os_log_t;
-  *X = os_log_create("org.llvm.signposts", OS_LOG_CATEGORY_POINTS_OF_INTEREST);
+  *X = os_log_create("org.llvm.signposts", "toolchain");
   return X;
 }
 struct LogDeleter {


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D123149.420594.patch
Type: text/x-patch
Size: 440 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220405/24757c11/attachment.bin>


More information about the llvm-commits mailing list