[PATCH] D122929: [BOLT] Check for !isTailCall in isUnconditionalBranch

Tue Apr 5 11:50:14 PDT 2022

maksfb requested changes to this revision.
maksfb added a comment.
This revision now requires changes to proceed.

Actually, I'm not convinced it's a great idea to check for the tail call here.

================
Comment at: bolt/test/AArch64/ext-double-jump.s:10
+  .align 4
+  .global dummy1
+  .type dummy1, %function
----------------
yota9 wrote:
> maksfb wrote:
> > nit: could you add size directives for functions in the test?
> Sure, will do. Does it affect something? I did it before, but usually BOLT works just fine without it, just curious
That's the proper way to mark functions in code. Ideally, you also need FDEs. Without this info, BOLT has to rely on heuristics to detect function boundaries.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122929/new/

https://reviews.llvm.org/D122929