[PATCH] D123143: SelectionDAG: Swap operands of atomic_store

[Jessica Clarke via Phabricator via llvm-commits]

jrtc27 added a comment.

This will be a lot of fun downstream...



================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUInstructions.td:520
-
-def atomic_store_8_#as : PatFrag<(ops node:$ptr, node:$val),
-                                 (atomic_store_8 node:$ptr, node:$val)>;
----------------
This contains a separate change?


================
Comment at: llvm/lib/Target/ARM/ARMInstrInfo.td:4139
 def : ARMPat<(ARMssat (shl GPRnopc:$Rn, imm0_31:$shft), imm0_31:$pos),
-               (SSAT imm0_31:$pos, GPRnopc:$Rn, imm0_31:$shft)>;                            
+               (SSAT imm0_31:$pos, GPRnopc:$Rn, imm0_31:$shft)>;
 def : ARMPat<(ARMssat (sra GPRnopc:$Rn, asr_imm:$shft), imm0_31:$pos),
----------------
Unrelated


================
Comment at: llvm/lib/Target/AVR/AVRInstrInfo.td:1442
     : Pseudo<(outs),
              (ins PTRRC
               : $rd, DRC
----------------
God this style is awful, looks like it's trying to be GNU extended asm syntax


================
Comment at: llvm/lib/Target/Hexagon/HexagonPatterns.td:2570
   def: Storea_pat<store,                      F64, addrgp, S2_storerdgp>;
-  def: Storea_pat<AtomSt<atomic_store_8>,     I32, addrgp, S2_storerbgp>;
-  def: Storea_pat<AtomSt<atomic_store_16>,    I32, addrgp, S2_storerhgp>;
-  def: Storea_pat<AtomSt<atomic_store_32>,    I32, addrgp, S2_storerigp>;
-  def: Storea_pat<AtomSt<atomic_store_32>,   V4I8, addrgp, S2_storerigp>;
-  def: Storea_pat<AtomSt<atomic_store_32>,  V2I16, addrgp, S2_storerigp>;
-  def: Storea_pat<AtomSt<atomic_store_64>,    I64, addrgp, S2_storerdgp>;
-  def: Storea_pat<AtomSt<atomic_store_64>,   V8I8, addrgp, S2_storerdgp>;
-  def: Storea_pat<AtomSt<atomic_store_64>,  V4I16, addrgp, S2_storerdgp>;
-  def: Storea_pat<AtomSt<atomic_store_64>,  V2I32, addrgp, S2_storerdgp>;
+  def: Storea_pat<atomic_store_8,     I32, addrgp, S2_storerbgp>;
+  def: Storea_pat<atomic_store_16,    I32, addrgp, S2_storerhgp>;
----------------
Keep these lined up?


================
Comment at: llvm/test/TableGen/GlobalISelEmitter-atomic_store.td:8
 
 // Check that the pattern for atomic_store inverts the operands to
 // match the order of G_STORE.
----------------
This comment seems to no longer apply


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123143/new/

https://reviews.llvm.org/D123143