[PATCH] D122824: [UpdateLLCTestChecks] Pick the correct output block when generating isel debug output checks in update_llc_test_checks.py

Sebastian Neubauer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 5 08:32:36 PDT 2022


Flakebi added inline comments.


================
Comment at: llvm/utils/UpdateTestChecks/isel.py:16
 
 # TODO: add function prefix
 ISEL_FUNCTION_DEFAULT_RE = re.compile(
----------------
I guess this TODO is fixed with this patch?


================
Comment at: llvm/utils/UpdateTestChecks/isel.py:18
 ISEL_FUNCTION_DEFAULT_RE = re.compile(
      r'Selected[\s]*selection[\s]*DAG:[\s]*%bb.0[\s]*\'(?P<func>.*?):[^\']*\'*\n'
      r'(?P<body>.*?)\n'
----------------
For consistency with the checked string below, maybe use spaces here for `Selected selection DAG: %bb.0`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122824/new/

https://reviews.llvm.org/D122824



More information about the llvm-commits mailing list