[PATCH] D122824: [UpdateLLCTestChecks] Add function prefix to make generated isel debug output checks runnable in update_llc_test_checks.py

[Yatao Wang via Phabricator via llvm-commits]

ningxinr added a comment.

In D122824#3421553 <https://reviews.llvm.org/D122824#3421553>, @Flakebi wrote:

> Just to check that I understand this correctly.
> Is the intention behind the function prefix to make it configurable in the end, so that one can also check for `Legalized selection DAG` and others?
>
> Or is it only to pick the right block, without making it configurable?
> Then I think it would be easier to use `check_label_format = '{} %s-LABEL: Selected selection DAG:{{.*}}%s%s:'`, which does not need any changes in common.py

You were right, this is much easier for my purpose. For this use case the function prefix is an invariant of function name and FileCheck prefixes, so we can just add it to the `check_label_format`. I suppose we could always change this later when the need of making it configurable rises.

Thank you, Sebastian! :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122824/new/

https://reviews.llvm.org/D122824