[PATCH] D122990: Added new file & improved inclusivity

Tue Apr 5 06:53:51 PDT 2022

aaron.ballman added a comment.

In D122990#3429176 <https://reviews.llvm.org/D122990#3429176>, @ps-19 wrote:

> In D122990#3429141 <https://reviews.llvm.org/D122990#3429141>, @aaron.ballman wrote:
>
>> Most of the changes LGTM, the only concerns I have left are around the READMEs. One thing we could do is split the question about what to do with READMEs off into a separate patch so that we can land the straightforward fixes now, if you'd like.
>
> Sir next i am planning to change all .txt into .md if had some time other than working on a choosen issue.
> I am waiting for your feedback weather or not revert that change of .txt -> .md.

I think you should remove the changes to `mlir/README.md` and revert the rename of `mlir/docs/README.txt`. Then I think the patch will be ready to land.

Separately, I'd recommend an additional patch that does the rename from `README.txt` to `README.md` for the entire monorepo so that all of the projects are handled consistently.

================
Comment at: mlir/README.md:3
+**Please visit the [website](https://mlir.llvm.org) for more information.**<br/>
+- *It is suggested to visit the website for better understanding.*
+
----------------
ps-19 wrote:
> Sir i hope it is fine now.
I think the original content was correct -- it was just a link to the website. What we want to avoid here is duplicating content on the website because then when we change the website, someone has to remember to also change this document (which someone will invariably forget to do, and then we may have conflicting information in two places).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D122990/new/

https://reviews.llvm.org/D122990