[PATCH] D123126: [cmake] Remove LLVM_ENABLE_NEW_PASS_MANAGER cmake option

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 5 06:26:08 PDT 2022


nikic created this revision.
nikic added reviewers: aeubanks, asbirlea.
Herald added subscribers: pmatos, asb, ormris, awarzynski, steven_wu, hiraditya, arichardson, sbc100, mgorny, emaste.
Herald added a reviewer: MaskRay.
Herald added projects: lld-macho, All.
Herald added a reviewer: lld-macho.
nikic requested review of this revision.
Herald added subscribers: llvm-commits, StephenFan, aheejin.
Herald added a project: LLVM.

Or rather, error out if it is set to something other than ON. This removes the ability to enable the legacy pass manager by default, but does not remove the ability to explicitly enable it through various flags like `-flegacy-pass-manager` or `-enable-new-pm=0`.

I checked, and our test suite definitely doesn't pass with `LLVM_ENABLE_NEW_PASS_MANAGER=OFF` anymore.


https://reviews.llvm.org/D123126

Files:
  clang/include/clang/Driver/Options.td
  clang/test/CMakeLists.txt
  clang/test/lit.cfg.py
  clang/test/lit.site.cfg.py.in
  clang/unittests/Frontend/CompilerInvocationTest.cpp
  lld/COFF/Driver.cpp
  lld/ELF/Driver.cpp
  lld/MachO/Config.h
  lld/MachO/Driver.cpp
  lld/wasm/Driver.cpp
  llvm/CMakeLists.txt
  llvm/cmake/modules/LLVMConfig.cmake.in
  llvm/docs/NewPassManager.rst
  llvm/include/llvm/Config/llvm-config.h.cmake
  llvm/include/llvm/LTO/Config.h
  llvm/include/llvm/LTO/legacy/ThinLTOCodeGenerator.h
  llvm/tools/gold/gold-plugin.cpp
  llvm/tools/llvm-lto/llvm-lto.cpp
  llvm/tools/llvm-lto2/llvm-lto2.cpp
  llvm/tools/opt/opt.cpp
  llvm/utils/gn/secondary/clang/test/BUILD.gn
  llvm/utils/gn/secondary/llvm/include/llvm/Config/BUILD.gn
  utils/bazel/llvm-project-overlay/llvm/include/llvm/Config/llvm-config.h
  utils/bazel/llvm_configs/llvm-config.h.cmake

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D123126.420484.patch
Type: text/x-patch
Size: 15987 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220405/998480d9/attachment.bin>


More information about the llvm-commits mailing list